Closed gligorkot closed 1 year ago
Closes #645
Updated integration tests workflow to run node and python integration tests, but only barely - removed the tests that were trying to deploy to Azure. Node workflow also runs validation script and the node tests.
The "Tag if new version" job runs as per Serverless framework repo here https://github.com/serverless/serverless/blob/a6bcc62182b6fe974d12d547c00e560882c55e05/.github/workflows/integrate.yml#L171.
In order for this to job to work a USER_GITHUB_TOKEN secret needs to be added with the 'serverless-ci' user authentication token as per Serverless framework. As per https://github.com/serverless/serverless/blob/a6bcc62182b6fe974d12d547c00e560882c55e05/.github/workflows/integrate.yml#L188-L190
USER_GITHUB_TOKEN
Added integration.yml in the github workflows.
The workflow will run once the PR has been merged, but you can verify the last run in my repository here https://github.com/gligorkot/serverless-azure-functions/actions/runs/4964935025
Note: Run npm run test:ci to run all validation checks on proposed changes
npm run test:ci
npm run lint
npm run lint:fix
npm test
Is this ready for review?: YES Is it a breaking change?: NO
What did you implement:
Closes #645
Updated integration tests workflow to run node and python integration tests, but only barely - removed the tests that were trying to deploy to Azure. Node workflow also runs validation script and the node tests.
Note:
The "Tag if new version" job runs as per Serverless framework repo here https://github.com/serverless/serverless/blob/a6bcc62182b6fe974d12d547c00e560882c55e05/.github/workflows/integrate.yml#L171.
In order for this to job to work a
USER_GITHUB_TOKEN
secret needs to be added with the 'serverless-ci' user authentication token as per Serverless framework. As per https://github.com/serverless/serverless/blob/a6bcc62182b6fe974d12d547c00e560882c55e05/.github/workflows/integrate.yml#L188-L190How did you implement it:
Added integration.yml in the github workflows.
How can we verify it:
The workflow will run once the PR has been merged, but you can verify the last run in my repository here https://github.com/gligorkot/serverless-azure-functions/actions/runs/4964935025
Todos:
Note: Run
npm run test:ci
to run all validation checks on proposed changesValidate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES Is it a breaking change?: NO