fix: remove unneeded `acorn` dependency

G-Rath commented 1 year ago

What did you implement:

The acorn package is no longer being used, so it doesn't need to be listed as a dependency.

How did you implement it:

I removed it from dependencies in package.json

How can we verify it:

❯ rg --files-with-matches 'acorn'
examples/typescript-webpack/package-lock.json
integrationTests/configurations/node12-linux/package-lock.json
integrationTests/configurations/node18-linux-webpack/package-lock.json
integrationTests/configurations/node14-windows/package-lock.json
integrationTests/configurations/node14-linux/package-lock.json
integrationTests/configurations/node16-linux/package-lock.json
integrationTests/configurations/node12-linux-webpack/package-lock.json
integrationTests/configurations/node18-windows-webpack/package-lock.json
integrationTests/configurations/node16-windows-webpack/package-lock.json
integrationTests/configurations/node14-windows-webpack/package-lock.json
integrationTests/configurations/node16-windows/package-lock.json
integrationTests/configurations/node16-linux-webpack/package-lock.json
integrationTests/configurations/node12-windows-webpack/package-lock.json
integrationTests/configurations/node18-windows/package-lock.json
integrationTests/configurations/node12-windows/package-lock.json
integrationTests/configurations/node14-linux-webpack/package-lock.json
integrationTests/configurations/node18-linux/package-lock.json
package-lock.json

If acorn was being used by this package, then there should have been a match in either a TypeScript or JavaScript file, which there was not.

The tests also will fail if acorn is actually needed.

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

[x] Ensure there are no lint errors.
Validate via npm run lint
Note: Some reported issues can be automatically fixed by running npm run lint:fix
[x] Write tests and confirm existing functionality is not broken.
Validate via npm test
[x] Write documentation
[x] Provide verification config / commands / resources
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

gligorkot commented 1 year ago

@G-Rath looks like acorn is used somewhere...

G-Rath commented 1 year ago

@gligorkot there you go - looks like it's being used by a dev dependency. I expect that'll probably go away later as part of upgrading eslint and the likes, but for now it doesn't need to be a standard dependency

gligorkot commented 1 year ago

Cool, happy with that. Thanks for updating it

serverless / serverless-azure-functions