Closed G-Rath closed 1 year ago
Removed lodash as a required dependency for this plugin.
lodash
I replaced the single usage of lodash with a native equivalent, and then I removed it from dependencies in package.json
dependencies
package.json
❯ rg --files-with-matches 'lodash' integrationTests/configurations/node16-linux-webpack/package-lock.json integrationTests/configurations/node12-linux/package-lock.json integrationTests/configurations/node18-linux-webpack/package-lock.json integrationTests/configurations/node14-windows/package-lock.json integrationTests/configurations/node16-linux/package-lock.json integrationTests/configurations/node12-linux-webpack/package-lock.json integrationTests/configurations/node18-windows-webpack/package-lock.json integrationTests/configurations/node16-windows-webpack/package-lock.json integrationTests/configurations/node14-windows-webpack/package-lock.json integrationTests/configurations/node16-windows/package-lock.json integrationTests/configurations/node18-windows/package-lock.json integrationTests/configurations/node12-windows-webpack/package-lock.json integrationTests/configurations/node12-windows/package-lock.json integrationTests/configurations/node14-linux-webpack/package-lock.json integrationTests/configurations/node14-linux/package-lock.json integrationTests/configurations/node18-linux/package-lock.json examples/typescript-webpack/package-lock.json package-lock.json
If lodash was being used by this package, then there should have been a match in either a TypeScript or JavaScript file, which there was not.
The tests also will fail if lodash is actually still needed.
Note: Run npm run test:ci to run all validation checks on proposed changes
npm run test:ci
npm run lint
npm run lint:fix
npm test
Is this ready for review?: YES Is it a breaking change?: NO
What did you implement:
Removed
lodash
as a required dependency for this plugin.How did you implement it:
I replaced the single usage of
lodash
with a native equivalent, and then I removed it fromdependencies
inpackage.json
How can we verify it:
If
lodash
was being used by this package, then there should have been a match in either a TypeScript or JavaScript file, which there was not.The tests also will fail if
lodash
is actually still needed.Todos:
Note: Run
npm run test:ci
to run all validation checks on proposed changesValidate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES Is it a breaking change?: NO