Adding support for nodejs20

serverless / serverless-azure-functions

Serverless Azure Functions Plugin – Add Azure Functions support to the Serverless Framework

MIT License

266 stars 159 forks source link

Adding support for nodejs20 #683

Open NiketaPopatChaudhari opened 3 months ago

NiketaPopatChaudhari commented 3 months ago

What did you implement: Adding support for Nodejs 20

How can we verify it: Use it to deploy a nodejs20 function app to Azure.

Todos: Note: Run npm run test:ci to run all validation checks on proposed changes

Ensure there are no lint errors. Validate via npm run lint Note: Some reported issues can be automatically fixed by running npm run lint:fix

Validate via npm test

Is this ready for review?: YES Is it a breaking change?: NO

gligorkot commented 3 months ago

@NiketaPopatChaudhari can you please add a validate for version 20 here:

https://github.com/serverless/serverless-azure-functions/blob/c9103a703941855862ad19fd96e807e34a8ad874/.github/workflows/validate.yml#L11

and integration for version 20 in 2 places:

NiketaPopatChaudhari commented 3 months ago

version 20 added in validate.yml and integration.yml

NiketaPopatChaudhari commented 3 months ago

Done

gligorkot commented 3 months ago

@NiketaPopatChaudhari looks like validate failed for node 20, can you please have a look, the failures can be found here https://github.com/serverless/serverless-azure-functions/actions/runs/8715495822/job/23909330268?pr=683

NiketaPopatChaudhari commented 3 months ago

Looking into @gligorkot

gligorkot commented 3 months ago

@NiketaPopatChaudhari you can try run the tests locally

NiketaPopatChaudhari commented 3 months ago

yes @gligorkot i am testing it on local and working on it to fix UT

NiketaPopatChaudhari commented 3 months ago

@gligorkot have tested on local with master branch Observation as below

Node Version 18.20.2 without any changes on the master branch

Node Version 20.12.1 without any changes on the master branch

gligorkot commented 3 months ago

@NiketaPopatChaudhari make sure you have cleared node_modules and re-installed them when running with node 18.

When I run node 18.20.2, all tests pass on the master branch for me:

However when I run using node 20.12.2 some of them do fail - can you please investigate what fails and what we need to do to fix these?

yashGanatraHK commented 3 months ago

Hey @gligorkot, @NiketaPopatChaudhari

I tried executing Tests (with Node Version: 20.12.2) in master branch (Without any changes) and it still fails in 27 cases. After having some research I could find out that its the test case code which is creating the issue here:

Most/Almost All of the failed cases are related to Mock FS module. Mock FS is already having Open issue with Node 20. Ref: https://github.com/tschaub/mock-fs/issues/384

We can try to change MockFs to MemFs but it will take some time to make these changes.

gligorkot commented 3 months ago

Hey @yashGanatraHK, thank you for looking into this issue. I'd first look at if removing mock-fs altogether is a viable approach, and failing that, yes updating to memfs would be my second choice.

NiketaPopatChaudhari commented 2 months ago

@gligorkot Have replaced all mockFs with memfs and made some additional changes now fail test count as below

gligorkot commented 2 months ago

@gligorkot Have replaced all mockFs with memfs and made some additional changes now fail test count as below

Thanks for keeping me in the loop @NiketaPopatChaudhari. Could you please have a look at what else needs changing to fix the remaining tests?

jonatandorozco commented 1 month ago

@gligorkot @NiketaPopatChaudhari please let me know if there is a way I can help with this

gligorkot commented 1 month ago

@gligorkot @NiketaPopatChaudhari please let me know if there is a way I can help with this

@jonatandorozco would you like to fork Niketa's branch and finish off the implementation then raise a PR for this?