serverless / serverless-google-cloudfunctions

Serverless Google Cloud Functions Plugin – Adds Google Cloud Functions support to the Serverless Framework
https://www.serverless.com
MIT License
272 stars 127 forks source link

feat: add support for allowUnauthenticated and custom IAM definitions #219

Closed edaniszewski closed 4 years ago

edaniszewski commented 4 years ago

This PR:

Note that I haven't tested this with an actual deploy because I'm not sure how use my fork of this plugin in a serverless configuration, but I can look into how to get that set up tomorrow.

Relates to:

edaniszewski commented 4 years ago

@medikoo Thanks for the review & suggestions. I don't use JS that often, so I'm glad to have another pair of eyes on it and to help me clean it up. I made updates for your suggestions - happy to make any more changes as needed.

thucnc commented 4 years ago

I got this error with this config:

 Error: Deployment failed: RESOURCE_ERROR

       {"ResourceType":"gcp-types/cloudfunctions-v1:projects.locations.functions","ResourceErrorCode":"404","ResourceErrorMessage":{"statusMessage":"Not Found","requestPath":"https://cloudfunctions.googleapis.com/v1/projects/[my-project]/locations/asia-northeast1/functions/test","httpMethod":"POST"}}

My config is:

deploy:
    runtime: nodejs10
    handler: test
    allowUnauthenticated: true
    events:
      - http: test
medikoo commented 4 years ago

@thucnc it's not published yet

thucnc commented 4 years ago

actually I overwrote my local package/lib/compileFunctions.js with the latest version in github.

saiaman commented 4 years ago

Same issue for me using the code in master

Le 25 juin 2020 à 11:46, Thuc Nguyen Canh notifications@github.com a écrit :

 actually I overwrote my local package/lib/compileFunctions.js with the latest version in github.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.