search

serverless / serverless-google-cloudfunctions

Serverless Google Cloud Functions Plugin – Adds Google Cloud Functions support to the Serverless Framework
https://www.serverless.com
MIT License
271 stars 127 forks source link

Adding support for egress and ingress settings #243

Open troykelly opened 3 years ago

troykelly commented 3 years ago

Resolves #242

functions:
  score:
    handler: score
    vpc: "projects/${self:provider.project}/locations/${self:provider.region}/connectors/my-vpc-name"
    egress: ALL_TRAFFIC
    ingress: ALLOW_ALL
    events:
      - http: score
ivanguimam commented 3 years ago

Hello, when will this be merged? I need this feature

medikoo commented 3 years ago

Hello, when will this be merged? I need this feature

@ivanguimam can you help us in finalizing this PR?

ivanguimam commented 3 years ago

Hello, when will this be merged? I need this feature

@ivanguimam can you help us in finalizing this PR?

How can I make these corrections being that PR belongs to someone else?

medikoo commented 3 years ago

How can I make these corrections being that PR belongs to someone else?

You can fork the repository, do updates, and propose another PR with updates

ivanguimam commented 3 years ago

How can I make these corrections being that PR belongs to someone else?

You can fork the repository, do updates, and propose another PR with updates

I'll try to do that by the weekend

medikoo commented 3 years ago

I'll try to do that by the weekend

@ivanguimam that'll be great. Thank you!

Ganitzsh commented 3 years ago

@ivanguimam awesome let us know!