search

serverless / serverless-google-cloudfunctions

Serverless Google Cloud Functions Plugin – Adds Google Cloud Functions support to the Serverless Framework
https://www.serverless.com
MIT License
271 stars 127 forks source link

Add some tests and change code style as requested #245

Open davidsoendoro opened 3 years ago

davidsoendoro commented 3 years ago

Hi, hope this helps. I also need this function so I try to change the code style as requested and add some test for the coverage and get it works in my travis ci and coveralls. Would be glad if this can make to the main repo.

davidsoendoro commented 3 years ago

Hi all, maybe I need to expand the explanation more. This is a continuation of pull request #243 which has not been merged due to some testing issues. I added those testing here and hopefully those are enough (if there were anything missing please give inputs). The ingress and egress option is useful since when we are using those and redeploy the serverless without these feature to GCF, the ingress and egress config will be overwritten. Hopefully this feature can make into the main repo since without it changing the ingress and egress after deployment in GCP console is inefficient (and defeat the purpose of using serverless framework I guess?).