serverless / serverless-google-cloudfunctions

Serverless Google Cloud Functions Plugin – Adds Google Cloud Functions support to the Serverless Framework
https://www.serverless.com
MIT License
271 stars 127 forks source link

feat: Add support for invoke local #258

Closed CorentinDoue closed 3 years ago

CorentinDoue commented 3 years ago

This pull request adds the implementation of the command invoke local for the google provider. It's inspired by the AWS implementation to keep the behaviors as close as possible.

The command is available for the nodejs runtimes and events of type event

Tests

Next steps

CorentinDoue commented 3 years ago

Screenshot from 2021-05-17 14-11-21 Screenshot from 2021-05-17 14-14-26

The failing test is caused by an unsupported for await by node 8. But node 8 is no more supported since https://github.com/serverless/serverless-google-cloudfunctions/releases/tag/v4.0.0

@pgrzesik could you remove the test with node8?

CorentinDoue commented 3 years ago

@pgrzesik can you review it?

pgrzesik commented 3 years ago

Hello @CorentinDoue - sorry for the delay here - I'm a bit swamped with other prorities and I'm not that familiar with this plugin's codebase, but I'll try to review it as soon as possible. Thanks for your patience :bow:

CorentinDoue commented 3 years ago

@pgrzesik I corrected or answered your remarks. It's ready for a new review