search

serverless / serverless-google-cloudfunctions

Serverless Google Cloud Functions Plugin – Adds Google Cloud Functions support to the Serverless Framework
https://www.serverless.com
MIT License
271 stars 126 forks source link

feat: Support `provider.vpcEgress` configuration #271

Closed fcr1193 closed 3 years ago

fcr1193 commented 3 years ago

Hey! I made some updates from this PR #250 (thanks @arei)

This PR address to issues with defining VPC connectors for a google cloud function:

  • First, VPC Connectors can be named with a url (which is the current pattern) or with just the name of the connector if it is within the same project and region. This is described here: https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions#resource:-cloudfunction
  • Second, this PR adds the ability to specify a VPC Egress setting. This is done using the vpcEgress property in the serverless.yml file. This property can take one of four different values:
    • ALL_TRAFFIC
    • PRIVATE_RANGES_ONLY
    • ALL (A shortcut for ALL_TRAFFIC)
    • PRIVATE (A shortcut for PRIVATE_RANGES_ONLY)

I would appreciate if you can give me feedback @pgrzesik

Thank you!

edgaregonzalez commented 3 years ago

Hi @pgrzesik, do you think that we can move this PR? This feature will be helpful. Thank you

fcr1193 commented 3 years ago

Hey @pgrzesik how are you? I just added some updates, let me know what you think! thanks!

fcr1193 commented 3 years ago

Hey @pgrzesik, how are you? thanks for your review, I just updated this!