search

serverless / serverless-google-cloudfunctions

Serverless Google Cloud Functions Plugin – Adds Google Cloud Functions support to the Serverless Framework
https://www.serverless.com
MIT License
271 stars 127 forks source link

Support V3 log interface #284

Open colemanja91 opened 2 years ago

colemanja91 commented 2 years ago

Add support for Serverless V3 logging (per #279 )

colemanja91 commented 2 years ago

@pgrzesik I kept it in WIP while doing some local testing with v3 - seems ready for a review!

pgrzesik commented 2 years ago

Thanks @colemanja91 👍 I'll run it locally to see if there's anything missing in the workflow. 👍

pgrzesik commented 2 years ago

Hello @colemanja91 - how did you verify it's properly working on local? I'm working with your branch locally and it doesn't seem to take the effect. Looking at the code it seems like the original setup of v3Utils log-related functions is happening at a wrong place or it's misused. You're using references to these helper functions on provider, but they're never assigned to provider. Am I missing something?