serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

case sensitive 'Kind' key #116

Closed gimlet2 closed 6 years ago

gimlet2 commented 6 years ago

That is really strange. But today after upgrade kubeless to version 0.6.0 serverless deploy started to fail with error: Message: Object 'Kind' is missing in '{"object":{"apiVersion":"kubeless.io/v1beta1","kind":"Function","metada After I've renamed key from kind to Kind it back to normal again. Can you please help me to understand is it a right fix or the problem is somewhere else. We use kubernetes versions

Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T21:07:38Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.16", GitCommit:"e8846c1d7e7e632d4bd5ed46160eff3dc4c993c5", GitTreeState:"clean", BuildDate:"2018-04-04T08:47:13Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
andresmgot commented 6 years ago

mm, that's weird, in the CI is happening the opposite, now that you have changed it for Kind it fails with:

  Code: 500
  Message: Object 'Kind' is missing in 'object has no kind field '

can you try to upgrade/reinstall serverless and the kubeless plugin? We haven't changed the API for the Function object in 0.6.0 so apparently the issue is not related to the Kubeless upgrade.

gimlet2 commented 6 years ago

I'll try. But on the same k8s cluster before upgrade it was working :/. Maybe it is smth in kubernetes client library you are using.

On Thu, Apr 26, 2018, 18:15 Andres notifications@github.com wrote:

mm, that's weird, in the CI is happening the opposite, now that you have changed it for Kind it fails with:

Code: 500 Message: Object 'Kind' is missing in 'object has no kind field '

can you try to upgrade/reinstall serverless and the kubeless plugin? We haven't changed the API for the Function object in 0.6.0 so apparently the issue is not related to the Kubeless upgrade.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/serverless/serverless-kubeless/pull/116#issuecomment-384700804, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuTKASh8u1iMy24g56dh7p5yz7zcF_Nks5tsfKagaJpZM4TlI0u .

andresmgot commented 6 years ago

It is a client-side error so it could be. If the above doesn't work you, can try with the version 0.4.0 of the plugin instead of 0.4.1? Maybe the latest version includes an update that makes it not compatible with Kubernetes 1.7.

gimlet2 commented 6 years ago

Thank you for advice. I'll try that too.

On Thu, Apr 26, 2018 at 6:32 PM, Andres notifications@github.com wrote:

It is a client-side error so it could be. If the above doesn't work you, can try with the version 0.4.0 of the plugin instead of 0.4.1? Maybe the latest version includes an update that makes it not compatible with Kubernetes 1.7.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/serverless/serverless-kubeless/pull/116#issuecomment-384706308, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuTKIMlqeLLpa3z0Ez0CNxafXkQ-wz0ks5tsfaPgaJpZM4TlI0u .

gimlet2 commented 6 years ago

I've tried version 0.4.0 and it works there. And that is strange, I've checked diffs between those releases and see nothing that can make it.

gimlet2 commented 6 years ago

Actually, I've tested more and it still broken the same way =(. I'll try to reinstall everything.

gimlet2 commented 6 years ago

Sorry for bothering you. But it works now. I've reinstall plugin, cleared all caches, removed function from cluster and deployed it again

andresmgot commented 6 years ago

I'm glad it finally worked :)