search

serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

Allow setting per-function annotations #137

Closed SomeoneWeird closed 6 years ago

SomeoneWeird commented 6 years ago

This makes it possible to use things like kube2iam which require annotations on the pod.

Eg.

functions:
  myFn:
    handler: handler.myFn
    annotations:
      iam.amazonaws.com/role: role-arn
andresmgot commented 6 years ago

Hi @SomeoneWeird, you will need to adapt the tests in order to proceed. You need to at least modify the function createDeploymentNocks of test/lib/mocks.js to include the empty object annotations.

SomeoneWeird commented 6 years ago

Yep - my bad. Thought I ran the tests but obviously didn't. Will fix.

SomeoneWeird commented 6 years ago

Should be all green now

andresmgot commented 6 years ago

thanks!