serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

feat: Adding CPU limits #139

Closed alexander-alvarez closed 6 years ago

alexander-alvarez commented 6 years ago

Hey @andresmgot

I put this together at the request of our DevOps engineer who suggested we have cpu limits defined for the serverless functions so they wouldn't be deprived of the necessary resources. I know the other serverless frameworks don't support this (e.g. https://serverless.com/framework/docs/providers/aws/guide/serverless.yml/) but since kubeless is ran on a kubernetes cluster with a finite amount of resources, IMO it makes sense to me that we have the ability to declare this, so the cluster can add more nodes if necessary and not deprive a serverless function of the resources it needs.

andresmgot commented 6 years ago

/LGTM thanks!