search

serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 81 forks source link

Q: NATS support #142

Closed nea closed 6 years ago

nea commented 6 years ago

Hey

As kubeless is supporting NATS now, is there also support planned via serverless-kubeless? Right now, if I add a trigger event in the serverless.yml it implicitly tries to Deploying Kafka trigger and fails obviously as I only have a NATS running.

Thanks a lot in advance

andresmgot commented 6 years ago

Hi,

Unfortunately that is not supported yet. If you want to contribute the project with that feature it will be more than welcome :). Basically we would need to mimic the same logic than with the KafkaTrigger but generate a NatsTrigger instead. We would need to have a field in the serverless.yaml as well to choose between Kafka or NATS (defaulting to Kafka).

nea commented 6 years ago

Hey @andresmgot

Ok, got it. Just wanted to check up on it. If I find time I will look into it.

But big thanks for giving me a heads up.

Thanks

nea commented 6 years ago

Hi @andresmgot

I created a PR #143 with NATS support.

As you mentioned, defaulting to Kafka to be backwards compatible, but also introducing new options to use NATS.

Hope this fits in the overall style. Otherwise just let me know.

Cheers