serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

Namespace not used when getting services and pods #159

Closed pstreule closed 5 years ago

pstreule commented 5 years ago

Fixes: #160

Background

The way our k8s access control is configured, users generally don't have permissions to list all pods or services in the cluster.

For example GET /api/v1/pods will fail with User "<user>" cannot list resource "pods" in API group "" at the cluster scope

Issue

Deploying using serverless deploy itself works, but the deployment progress checks fail, as these use /api/v1/pods and /api/v1/services.

The deployment code is namespace-aware, so I think the progress checks should use the namespaced APIs, too, i.e. /api/v1/namespaces/<namespace>/pods.

pstreule commented 5 years ago

Thanks a lot for the quick review! I haven't synced my fork for a while, and the correct version now seems to be 0.6.1? I bumped to this version.

andresmgot commented 5 years ago

Oh, you are right, the correct version is 0.6.1. Thanks for updating it!