search

serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

Unable to use kubeless installed in any namespace other than 'kubeless' #174

Closed d0x2f closed 5 years ago

d0x2f commented 5 years ago

You can see here the default namespace to look for the config-map is 'kubeless':

https://github.com/serverless/serverless-kubeless/blob/master/lib/config.js#L25

And you can see here that the Config object is constructed with no other options given:

https://github.com/serverless/serverless-kubeless/blob/master/deploy/kubelessDeploy.js#L84

Thus the config-map is only ever able to be fetched from the 'kubeless' namespace.

andresmgot commented 5 years ago

Yes, that's correct. Would you able to send a PR to fix that? The easiest solution would be to read an env var at that point. The kubeless CLI uses KUBELESS_NAMESPACE for that.

d0x2f commented 5 years ago

Sure I'll give it a go.