search

serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

Adds support for separate ingress class and ingress names. #181

Closed MPratley closed 5 years ago

MPratley commented 5 years ago

This PR lets users optionally specify an ingress name alongside the class, with the following syntax:

provider:
  name: kubeless
  ingress: 
    class: "azure/application-gateway"
    name: "appgw" # <- New!

This is necessary to support Azure's Application Gateway Ingress Controller (AGIC), as its class azure/application-gateway contains a /, which is an illegal character in annotation names.

See here for an example of the AGIC class

And here for an example of the (different) name AGIC has in annotations

andresmgot commented 5 years ago

@MPratley Do you mind bumping the version of the package so it gets automatically released?

MPratley commented 5 years ago

@MPratley Do you mind bumping the version of the package so it gets automatically released?

@andresmgot done 👍. Thanks for the speedy approval! : )

MPratley commented 5 years ago

As a semi-related aside, I put a documentation PR into the serverless repo https://github.com/serverless/serverless/pull/6513