search

serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

added url+zip deploy method #187

Closed vognev closed 5 years ago

vognev commented 5 years ago

I'd like to be able to define in which way function should be deployed (either as zip+base64 or as url+zip)

for that, i'm going to implement deployment strategy, which will upload function .zip to s3 bucket and then replace f.content with actual url

not going to implement advanced functionality like deleting old .zips etc, just a pretty basic stuff

what community thinks about it?

sebgoa commented 5 years ago

Hi, you want to upload the source of a kubeless function to S3 ?

vognev commented 5 years ago

yes, thinking about in-cluster minio, actually

sebgoa commented 5 years ago

ah Ok S3 via minio. We thought about this early in the kubeless days, but that felt like a big dependency to have.

As long as you can also live in a setup that does not have it then why not.

vognev commented 5 years ago

As long as you can also live in a setup that does not have it then why not.

function-content-type is still base64+zip on default

vognev commented 5 years ago

@sebgoa so, any chance for this to be merged?

sebgoa commented 5 years ago

I would love to hear more about your kubeless use-case, would be great if you could contact me at runseb@gmail.com

@andresmgot might still be maintaining this codebase so I will let him to decide if he wants to merge or not.

andresmgot commented 5 years ago

Hi @vognev, thank you for the PR! Yes, I will check it and give feedback (long time I haven't add a major feature to this plugin so let me setup the environemtn and get back to you).

vognev commented 5 years ago

Docs update PR is here - https://github.com/serverless/serverless/pull/6721

vognev commented 5 years ago

@andresmgot pending things done

andresmgot commented 5 years ago

@vognev thanks!