search

serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

Pass AWS_PROFILE value as an environment variable #196

Closed Suckzoo closed 4 years ago

Suckzoo commented 4 years ago

Thanks to contributors, dynamic EKS credentials have been supported since the following PRs(https://github.com/serverless/serverless-kubeless/pull/189, https://github.com/serverless/serverless-kubeless/pull/192).

However, the above commits did not properly passed the AWS_PROFILE value: aws-iam-authenticator breaks because it does not know the --profile argument. Thus, I created another envvar map for child process, put AWS_PROFILE value inside the map, and passed the map to the child process.

Passing AWS_PROFILE as an environment variable will not break aws.

bradleybluebean commented 4 years ago

Setting the profile via environment variable looks good to me. Thanks!

Suckzoo commented 4 years ago

@andresmgot Just increased the version and pushed.