search

serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 81 forks source link

Manual ingress vs HTTP Trigger #205

Closed faxioman closed 4 years ago

faxioman commented 4 years ago

I see that the plugin is directly creating an http ingress instead of creating a kubeless http trigger. Is there a chance that this odd behaviour will change in the near future?

Thanks!

faxioman commented 4 years ago

Ok, the reason for this behaviour is now clear:

case 'http':
      // TODO: Rely on Kubeless httptrigger object when it support paths
      break;

Has this implementation already started? The httptrigger is supporting paths now.

andresmgot commented 4 years ago

yes, that's correct but we never had the time to implement that. Accepting contributions here!

faxioman commented 4 years ago

@andresmgot ok, I'm preparing a pull request

faxioman commented 4 years ago

Ok, pull request pushed: https://github.com/serverless/serverless-kubeless/pull/206

faxioman commented 4 years ago

206 merged