search

serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 81 forks source link

waitForDeployment should also waits for service presence #213

Closed faxioman closed 4 years ago

faxioman commented 4 years ago

The "waitForDeployment" method in deploy.js module is waiting for running function pods before creating other resources (eg triggers). It should also waits for the presence of the service used by the deployed function. Without this pull request the creation of some resource could fail. Thus the creation of an HTTP Trigger sometimes fails because the function is deployed but the service isn't.

faxioman commented 4 years ago

Some checks fail intermittently. I think it's unrelated to my changes.

andresmgot commented 4 years ago

Thanks @faxioman! Do you mind bumping the package version so this gets released?

faxioman commented 4 years ago

@andresmgot ok. I've also increased the retry loop from 3 to 10. For some runtime with a build phase, three checks aren't enough.

faxioman commented 4 years ago

Hi @andresmgot. Have you already planned to release the 0.10.1 version to npm? Thanks!

andresmgot commented 4 years ago

Hi @faxioman the CI failed and it didn't release that version. I've published it manually.