serverless / serverless-kubeless

This plugin enables support for Kubeless within the Serverless Framework.
Apache License 2.0
303 stars 80 forks source link

Add support for custom runtime image #84

Closed ccll closed 6 years ago

ccll commented 6 years ago

Allow the user optionally specify custom runtime image with:

  1. service.provider.image
  2. service.provider.functions.<function_id>.image The second one overrides the first one.

closes #81

vjm commented 6 years ago

@ccll and @andresmgot it looks like this removes the volumeMount from the container spec. The following is not present when using a custom image:

volumeMounts:
    - mountPath: /kubeless

Am I doing something wrong?

andresmgot commented 6 years ago

@vjm when using a custom image the build process is skipped so it doesn't try to mount the function content. It assumes that the function is already in the image provided. See more info here: https://kubeless.io/docs/runtimes/#use-a-custom-runtime

If what you want is to define a new base image to inject functions in top of it you need to modify the Kubeless configmap (as explained in the documentation).

vjm commented 6 years ago

Thanks for the quick reply @andresmgot ! I'll try that out.