search

serverless / serverless-openwhisk

Adds Apache OpenWhisk support to the Serverless Framework!
http://openwhisk.org/
MIT License
143 stars 47 forks source link

Fixed alarm annotations of trigger can not be saved #168

Closed KeonHee closed 5 years ago

KeonHee commented 5 years ago

167

If the feed exists, I changed it to match the ow.trigger.create()'s parameter format. I have also added tests for this

codecov[bot] commented 5 years ago

Codecov Report

Merging #168 into master will increase coverage by 0.24%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage    84.8%   85.04%   +0.24%     
==========================================
  Files          47       47              
  Lines        1829     1826       -3     
  Branches      378      378              
==========================================
+ Hits         1551     1553       +2     
+ Misses        278      273       -5
Impacted Files Coverage Δ
deploy/lib/deployTriggers.js 73.91% <87.5%> (+16.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84ca5ac...be5a3a7. Read the comment docs.

style95 commented 5 years ago

@jthomas Could you have a look at this? It seems we are unable to create a trigger with feed using the latest serverless framework. (More precisely, the feed annotation is not added in the trigger information.)

jthomas commented 5 years ago

@style95 Let me have a look at this tomorrow.

style95 commented 5 years ago

@jthomas Thank you so much.