search

serverless / serverless-openwhisk

Adds Apache OpenWhisk support to the Serverless Framework!
http://openwhisk.org/
MIT License
143 stars 46 forks source link

feat: iam enablement #172

Closed dpittner closed 5 years ago

dpittner commented 5 years ago

WIP for IAM

codecov[bot] commented 5 years ago

Codecov Report

Merging #172 into master will decrease coverage by 0.16%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   85.04%   84.87%   -0.17%     
==========================================
  Files          47       47              
  Lines        1826     1832       +6     
  Branches      378      379       +1     
==========================================
+ Hits         1553     1555       +2     
- Misses        273      277       +4
Impacted Files Coverage Δ
provider/openwhiskProvider.js 88.57% <50%> (-11.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2db381...653008a. Read the comment docs.

jthomas commented 5 years ago

@dpittner Thanks for opening this - code LGTM.

Can you add unit tests to validate this works? Also, code indent needs correcting a bit.

jthomas commented 5 years ago

I've taken these changes and integrated them into master now. The framework takes an explicit environment parameter (OW_IAM_NAMESPACE_API_KEY) with the platform API key. The existing OW_NAMESPACE env var is used to provide the IAM namespace identifier.

https://github.com/serverless/serverless-openwhisk/commit/9e6930f8fd8de94adbca2c5b69e0dcc5fc5a28e4