search

serverless / serverless-openwhisk

Adds Apache OpenWhisk support to the Serverless Framework!
http://openwhisk.org/
MIT License
143 stars 46 forks source link

Remove default implicit configuration that sets the concurrency to 1 #183

Closed cjelger closed 5 years ago

cjelger commented 5 years ago

If the concurrency of an action is not configured, the plugin sets it to 1 by default, because of https://github.com/serverless/serverless-openwhisk/blob/1de03125ab7bcbf2d27d5a3ab2eb17f9b53500b6/compile/functions/index.js#L58

This is a problem because it overrides the default concurrency that can be set by default on the Openwhisk platform itself. So for example, if the platform defines a default concurrency of 200, not setting it in the serverless config "silently" resets this to 1.

I'll provide a PR for that.

cjelger commented 5 years ago

@jthomas I'm wondering if we also want to do the same removal of the default values for the memory and timeout parameters. WDYT?

cjelger commented 5 years ago

@jthomas Gentle ping wrt. the previous comment, thanks.

jthomas commented 5 years ago

@cjelger +1 that's good idea.