search

serverless / serverless-openwhisk

Adds Apache OpenWhisk support to the Serverless Framework!
http://openwhisk.org/
MIT License
143 stars 46 forks source link

Remove default implicit configuration that sets the concurrency to 1 … #184

Closed cjelger closed 5 years ago

cjelger commented 5 years ago

…#183

codecov[bot] commented 5 years ago

Codecov Report

Merging #184 into master will increase coverage by 1.49%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   85.44%   86.94%   +1.49%     
==========================================
  Files          49       49              
  Lines        1883     1884       +1     
  Branches      385      386       +1     
==========================================
+ Hits         1609     1638      +29     
+ Misses        274      246      -28
Impacted Files Coverage Δ
compile/functions/index.js 92.85% <100%> (+33.82%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 447d3fb...6fdf39f. Read the comment docs.

cjelger commented 5 years ago

@jthomas I'd have liked to adapt unit tests but I have been surprised there isn't any for the compileFunction method. Shall I add one, or did you have a reason not to have one?

jthomas commented 5 years ago

@cjelger Please add as many unit tests are you like :)

cjelger commented 5 years ago

Done in the mean time, I added one to cover the compileFunctions method.

cjelger commented 5 years ago

Closes #183