search

serverless / serverless-optimizer-plugin

Serverless Optimizer Plugin: Optimizers for reducing Lambda file sizes and improving their performance -
http://www.serverless.com
102 stars 30 forks source link

What's the plan with Babelify support? #5

Closed bugeats closed 8 years ago

bugeats commented 8 years ago

I see that the call to babelify was removed in the 0.1.0 release, and I see that the config signature was simplified, but it's not clear to me where babelify is meant to fit in now.

I'd like to work on this. Is there a plan?

austencollins commented 8 years ago

@bugeats In the v0.1 refactor, I implemented the majority of this pull request, which I thought was quite nice: https://github.com/serverless/serverless-optimizer-plugin/pull/1 There is definitely support for Babel in there. However, I'm not a babel developer, so I sort of left it hanging. If you want to continue the work and ensure Babel support is working properly, I will be gladly merge it in. Though I do want to make sure we keep the current config settings because they allow people to pass all types of things (in addition to Babel) to Browserify. So please dig in and let's make this an awesome plugin!!

austencollins commented 8 years ago

@bugeats I think we're good here thanks to your great work. I'm going to close this. Thanks again :)