serverless / serverless-plugin-log-retention

Control the retention of your serverless function's cloudwatch logs.
MIT License
21 stars 17 forks source link

Update to new lifecycle hook, `package` to remove deprecation warning #1

Closed MichaelRBond closed 5 years ago

MichaelRBond commented 6 years ago

Usage invokes the following warning from SLS: Serverless: WARNING: Plugin AwsAddLogRetention uses deprecated hook before:deploy:createDeploymentArtifacts, use package:createDeploymentArtifacts hook instead

1) Update to new life cycle method package 2) Update Tests

Making this change removes the deprecation warning when deploying.

rhussmann commented 6 years ago

@ArtificerEntertainment could you take a look at this? It would cleanup some noise during serverless deployments and comply with the newer lifecycle stages.

MichaelRBond commented 6 years ago

@ArtificerEntertainment any word on this pull request please? thanks.

gozup commented 5 years ago

👍

ArtificerEntertainment commented 5 years ago

Thank you for the contribution.