search

serverless / serverless-plugin-log-retention

Control the retention of your serverless function's cloudwatch logs.
MIT License
21 stars 17 forks source link

Log retention is not set when threre no aws resources in project #5

Open fernandomoraes opened 3 years ago

fernandomoraes commented 3 years ago

If the project contains none aws resources, the log retention is not set, this happens due to a bug in the implementation logic.

fernandomoraes commented 3 years ago

4

szabolcsmaj commented 3 years ago

Can @ArtificerEntertainment or @MichaelRBond merge this?

MichaelRBond commented 3 years ago

I cannot.

janfeshanmehran commented 3 years ago

is there any update on this MR?

szabolcsmaj commented 3 years ago

After a lot of googling, I found the owner (at least I think it is) of the account @ArtificerEntertainment . I wrote an email to him but he didn't answer at all. He could at least give/share the ownership of the repo so that It can be improved without him.

Jalle19 commented 3 years ago

I tried this plugin in order to replace having to define custom resources for each log group just to be able to change their retention time, only to find out it didn't work because I removed the whole resources section...

@ArtificerEntertainment please, merge this.

janfeshanmehran commented 3 years ago

I do appreciate it if, anyone can merge this PR

joquijada commented 3 years ago

After a lot of googling, I found the owner (at least I think it is) of the account @ArtificerEntertainment . I wrote an email to him but he didn't answer at all. He could at least give/share the ownership of the repo so that It can be improved without him.

It's a shame the owner is not actively monitoring this. I opened PR #8 but I guess there won't be any luck getting that merged in anytime soon. Anyone in favor of forking this project? @ArtificerEntertainment or @MichaelRBond

MichaelRBond commented 3 years ago

I don't have permissions to perform the merge. Sorry :-(

We do use this plugin in a number of projects, and I'd like to see it maintained as well.

Are there a couple people that would like to be owners / maintainers? If we can find a couple people it might be easier to sustain over time with a fork.