search

serverless / serverless-python-requirements

⚡️🐍📦 Serverless plugin to bundle Python packages
MIT License
1.09k stars 289 forks source link

feat: support custom git config #833

Closed shaug closed 1 month ago

shaug commented 3 months ago

This allows for, among other things, relying on git URL mappings, which can normalize protocols:

git config --global url."ssh://git@github.com".insteadOf "https://github.com"

Or add credentials from environment variables for a CI tool:

git config --global \
    url."https://${USERNAME}:${PASSWORD}@github.com/${OWNER}/".insteadOf \
    "https://github.com/${OWNER}/"

I have a project relying on this change and it is working spendidly.

pgrzesik commented 3 months ago

Hey @shaug - thanks a lot for the proposal, overall it makes sense 👍 There are failing checks in CI though (prettier-related it seems), could you please take a look into that?

shaug commented 3 months ago

Thanks, @pgrzesik. The code has been prettified.

pgrzesik commented 3 months ago

Hey @shaug - unfortunately it seems like the tests are failing as well - if you'd be able to take a look it will be much appreciated 🙇

shaug commented 1 month ago

I'm having too many problems figuring out how to get the unit tests to work. I'll figure out a different solution.

pgrzesik commented 1 month ago

Sounds good, please let me know if there's a way I could help 👍