serverless / template

Compose & provision a collection of Serverless Components
https://serverless.com
Apache License 2.0
10 stars 6 forks source link

Ensure to list used dependency in package.json #11

Open medikoo opened 4 years ago

medikoo commented 4 years ago

It's used at https://github.com/serverless/template/blob/fdc1924136d13e06200917cced8227de53b6d2b3/utils.js#L2 while not referenced in package.json.

It works by chance that @serverless/core uses it and that most package managers installs deps flat way. Still it may break for some totally valid install scenarios, and also without that we do not guard version we depend on here.

btw. we may consider relying on @serverless/eslint-config as it'll prevent such setup errors (also having some tests will expose it)