search

serverless / utils

General serverless utilities
MIT License
30 stars 22 forks source link

Type definitions are missing #166

Open nikolaymatrosov opened 2 years ago

nikolaymatrosov commented 2 years ago

There are no type definitions for TypeScript. It causes errors.

medikoo commented 2 years ago

@nikolaymatrosov it's not a TypeScript but a plain JavaScript project (same as the Serverless Framework).

Also, this package serves internal utils for the Serverless Framework, as is not intended for public use in its form directly.

nikolaymatrosov commented 2 years ago

It is mentioned in the docs as a convenient way to retrieve the logger. I'm writing my plugin in TypeScript, so it would be great to have an opportunity to use the utils package there.

medikoo commented 2 years ago

It is mentioned in the docs as a convenient way to retrieve the logger.

Indeed forgot about that. but note It's not a TypeScript project, so there's nothing wrong with it not having TS type definitions.

Nonetheless, I agree, that for improved IntelliSense it'll be helpful to provide typings. if you see an easy, non-invasive way to add them, PR's welcome.