search

serverlesstechnology / cqrs

A lightweight, opinionated CQRS and event sourcing framework.
Other
346 stars 36 forks source link

move the demo application into this repo #43

Closed danieleades closed 1 year ago

danieleades commented 1 year ago

the demo application should probably be moved into this repo, and this repo modified to be a cargo workspace

this ensures that this library and the demo application are updated in lockstep.

I had a quick go at this, but ran into some subtle version issues. I suspect postgres-es would also need to be added to the workspace to prevent multiple different versions of cqrs being pulled into the dependency tree

davegarred commented 1 year ago

Thanks for the input @danieleades. I would like to avoid pulling any of the persistence modules into this project to keep things clean, particularly for users that may use a custom persistence mechanism or to avoid issues adding new databases.

I've considered combining the persistence modules (using feature flags to select the desired database) but on initial tries at this I've run into conflicts (particularly with later versions of the MySql driver) and thus opted to keep things separated for now.

It would certainly be nice to have less crates to manage though so we should think about this in the future as things stabilize (though with the speed that Rust moves I'm not sure when or if that will happen).

danieleades commented 1 year ago

sure thing. To be clear, i'm not proposing adding the repos to this crate, but to store them in this repo as separate crates in a Cargo workspace