search

serverlessworkflow / sdk-typescript

Typescript SDK for Serverless Workflow
https://serverlessworkflow.io/
Apache License 2.0
64 stars 16 forks source link

validate method return proprietary class #112

Closed antmendoza closed 3 years ago

antmendoza commented 3 years ago

Many thanks for submitting your Pull Request :heart:!

What this PR does / why we need it:

errors property in workflowValidation class is defined as a list of DefinedError from ajv library, I think that this class should be replaced for a proprietary class, like validationError in this case

Special notes for reviewers:

Additional information (if needed):

JBBianchi commented 3 years ago

Thanks for this improvement @antmendoza !

antmendoza commented 3 years ago

are you happy with this PR @JBBianchi? can I merge it ?

JBBianchi commented 3 years ago

s'all good man, thanks :)