serverlessworkflow / specification

Contains the official specification for the Serverless Workflow Domain Specific Language. It provides detailed guidelines and standards for defining, executing, and managing workflows in serverless environments, ensuring consistency and interoperability across implementations.
http://serverlessworkflow.io
Apache License 2.0
742 stars 147 forks source link

404 when trying to parse 'workflow.json' schema: 'secrets.json' not found #394

Closed cdavernas closed 3 years ago

cdavernas commented 3 years ago

What happened:

A 404 is returned when trying to access the following url, when parsing the SW schema:

https://serverlessworkflow.io/schemas/0.7/secrets.json

What you expected to happen:

Everything to work as expected

How to reproduce it:

Try validating a workflow with any of the SDKs that support schema-based validation (TypeScript, .NET, ...)

How to fix it:

Add the secrets.json file into the website's repo

Anything else we need to know?:

Furthermore, the idspecified in the secrets.json file is incorrect.

Environment:

tsurdilo commented 3 years ago

good catch on the id! will fix asap. we merged the pr yesterday and just havent had the chance to update website. will link the website commit when it done

On Tue, Jun 1, 2021 at 10:09 AM cdavernas @.***> wrote:

Assigned #394 https://github.com/serverlessworkflow/specification/issues/394 to @tsurdilo https://github.com/tsurdilo.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/serverlessworkflow/specification/issues/394#event-4825666181, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5E7SKV66FPA3OAFGEHTLTQTS2BANCNFSM454YFFLQ .

cdavernas commented 3 years ago

Thanks @JBBianchi for the id, he's the one that spotted it.

tsurdilo commented 3 years ago

https://github.com/serverlessworkflow/serverlessworkflow.github.io/commit/ce16f8bfe36b83b108078041c3d341c66f5db272

tsurdilo commented 3 years ago

@cdavernas this can be closed now i think

cdavernas commented 3 years ago

@tsurdilo it can! Many thanks!