search

serverlessworkflow / specification

Contains the official specification for the Serverless Workflow Domain Specific Language. It provides detailed guidelines and standards for defining, executing, and managing workflows in serverless environments, ensuring consistency and interoperability across implementations.
http://serverlessworkflow.io
Apache License 2.0
730 stars 146 forks source link

Examples README samples are broken #822

Closed JBBianchi closed 3 months ago

JBBianchi commented 6 months ago

What seems off: The include of example sample seems to break the readme layout: image

What you expected to be: The layout to be nice and clean.

ricardozanini commented 6 months ago

Hey @JBBianchi thanks for reporting it! Are you willing to fix it? :D

JBBianchi commented 6 months ago

Yes, it's just a line return that needs to be added.

RamiKassouf commented 5 months ago

It's broken again

JBBianchi commented 5 months ago

It's broken again

It hasn't been regenerated so far, so it's "still" broken :)

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ricardozanini commented 4 months ago

@JBBianchi is this fixed?

JBBianchi commented 4 months ago

@JBBianchi is this fixed?

When https://github.com/serverlessworkflow/specification/pull/836 is merged we'll know for sure, but it should be.

JBBianchi commented 4 months ago

It looks like the workflow to hydrate the readme is broken: https://github.com/serverlessworkflow/specification/actions/workflows/examples-readme-hydration.yml

Either because the BOT_PAT secret is missing or the bot doesn't have the rights on the repository.

ricardozanini commented 4 months ago

That's weird, I'll take a look later

cdavernas commented 3 months ago

@JBBianchi @ricardozanini Can you fix that for 0.9, meaning now, or should we close it as part of #843 ?

JBBianchi commented 3 months ago

I think it would be a good thing to fix the bot config. Even if the examples are dropped with the next version, we'll still need a functioning bot in the future.

cdavernas commented 3 months ago

@ricardozanini Can you please address that?

ricardozanini commented 3 months ago

Closing this since we don't have this pipeline nor the examples README anymore.

cdavernas commented 3 months ago

I think this must be fixed on 0.9.0

ricardozanini commented 3 months ago

@cdavernas I'll reopen but it might stale. I'd keep it close and if there's momentum we'll notice since the CI will fail, then we can fix it. I'm investing my time on 1.0.0 atm. Feel free to reopen.

cdavernas commented 3 months ago

I'm investing my time on 1.0.0 atm

Not shit! 😆 Me too 🎉