search

serversideup / docker-php

🐳 Production-ready Docker images for PHP. Optimized for Laravel, WordPress, and more!
https://serversideup.net/open-source/docker-php/
GNU General Public License v3.0
1.71k stars 113 forks source link

Check shell scripts #333

Open szepeviktor opened 5 months ago

szepeviktor commented 5 months ago

Steps To Reproduce

Please use shellcheck on shell scripts.

Host Operating System

Win95

szepeviktor commented 4 months ago 
        steps:
        -
            name: "Checkout repository"
            uses: "actions/checkout@v4"
        -
            name: "Run ShellCheck"
            uses: "ludeeus/action-shellcheck@2.0.0"
jaydrogers commented 4 months ago

Sweet, thanks for the follow up! I'll get this implemented once I get through some other features.

Thanks agian @szepeviktor!

szepeviktor commented 4 months ago

once I get through some other features

@jaydrogers The natural way is to write shell scripts while using shellcheck.

jaydrogers commented 4 months ago

For sure. I see it in VSCode and I've been getting better at cleaning things up as I go.

Always learning something new everyday 😃