Closed jaydrogers closed 3 months ago
Latest commit: |
98db16e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f724b34f.serversideup-php.pages.dev |
Branch Preview URL: | https://improve-healthchecks.serversideup-php.pages.dev |
Please don't introduce breaking changes like these without communicating or upgrading major versions
My applications have been failing just because the old /ping endpoint does not work :/
Sorry for the breaking change! I didn’t think it was going to cause problems like that.
If you have a lot of automation in your environment, I would suggest locking into a version like this: https://hub.docker.com/r/serversideup/php/tags?page=1&page_size=&ordering=-name&name=8.3-fpm-nginx-v
Also, be sure to subscribe to releases here https://serversideup.net/open-source/docker-php/docs/getting-started/upgrade-guide#subscribe-to-repository-updates
Problem
If we only allow health checks to be to
/ping
, this only verifies the PHP stack is online (and not actually the applicaiton)What this PR does
HEALTHCHECK_PATH
(default:/ping
)🎥 Video
Check this video for more details: https://twitter.com/jaydrogers/status/1790726134981706185
Example Health Check
ToDos
Health Check Checklist
The following items should be checked on updating the health checks:
All
S6
data/check
script has been updatedApache
Unit
Testing