serversideup / docker-php

🐳 Production-ready Docker images for PHP. Optimized for Laravel, WordPress, and more!
https://serversideup.net/open-source/docker-php/
GNU General Public License v3.0
1.65k stars 108 forks source link

Configure permissions on /run directory for compatibility with cloud providers #385

Closed jaydrogers closed 2 months ago

jaydrogers commented 2 months ago

What this PR does

Related Discussions

Co-authored by

jaydrogers commented 2 months ago

@hajekj: I have the images publishing now under my own branch. This should fix all the non-sense with GitHub Actions.

These tags will be prefixed with the PR number now.

Example:

docker.io/serversideup/php-dev:385-7.4.33-cli-alpine  
docker.io/serversideup/php-dev:385-7.4-cli-alpine  
docker.io/serversideup/php-dev:385-7.4-alpine  
docker.io/serversideup/php-dev:385-7-cli-alpine  
docker.io/serversideup/php-dev:385-7-alpine  

Once this is done, if you can confirm the changes are there and work that would be great.

I would test the following Operating System variations to be sure this works across the board:

If this does not work

We can do the chown -R 755 as you initially proposed. I am just trying to take the "least privilege" route.

Thanks for your patience and dedication on this issue!

hajekj commented 2 months ago

That did the job - http://container-apps-test--jafwdzh.purplemoss-bcf270ea.westeurope.azurecontainerapps.io/

The image is now running in Azure just fine.

jaydrogers commented 2 months ago

Sweet! Thanks for the update!

Did it work on the other operating systems too?

hajekj commented 2 months ago

The builds are now complete, so managed to test all of those you listed.

jaydrogers commented 2 months ago

Thanks a ton for your help @hajekj!

I have this merged and it will be released soon.

I might do a beta release with this one then merge it to stable later on.