search

serversideup / docker-php

🐳 Production-ready Docker images for PHP. Optimized for Laravel, WordPress, and more!
https://serversideup.net/open-source/docker-php/
GNU General Public License v3.0
1.65k stars 108 forks source link

changed case of `as` to `AS` to stay inline with convention #392

Closed chinmaypurav closed 1 month ago

chinmaypurav commented 1 month ago

https://docs.docker.com/reference/dockerfile/#format

However, convention is for them to be UPPERCASE to distinguish them from arguments more easily.

jaydrogers commented 1 month ago

Thanks for the suggestion!

20x-dz commented 3 weeks ago

The different cases also trigger a warning when launching the containers, see https://docs.docker.com/reference/build-checks/from-as-casing/

Thank you for adjusting the styles.