serversideup / spin

🚀 Replicate your production environment locally using Docker. Just run "spin up". It's really that easy.
https://serversideup.net/open-source/spin/
GNU General Public License v3.0
1.21k stars 43 forks source link

Some suggestions for the deploy command #82

Closed nckrtl closed 4 months ago

nckrtl commented 5 months ago

This would also work:

configs:
  traefik:
    name: 'traefik-${SPIN_TRAEFIK_YML_CONFIG_MD5_HASH}.yml'
    file: ./.infrastructure/conf/traefik/prod/traefik.yml
  redis:
    name: 'redis-${SPIN_REDIS_CONF_CONFIG_MD5_HASH}.yml'
    file: ./.infrastructure/conf/redis/prod/redis.conf

Maybe we could drop the CONFIG part, so it becomes {SPIN_TRAEFIK_YML_MD5_HASH}

nckrtl commented 5 months ago

An few examples of what the stack templates could look like with these changes: redis: https://github.com/nckrtl/spin-redis traefik: https://github.com/nckrtl/spin-traefik

jaydrogers commented 4 months ago

Wow, this is AWESOME!! Thanks @nckrtl!

I give you a lot of credit for going through this, because even I had a hard time reading my code 😆

Thanks for the clean up efforts on this. I really like where this is going. I appreciate your help!

jaydrogers commented 4 months ago

I was so excited to thank you, I forgot to mention...

Changes I made

Thoughts?

nckrtl commented 4 months ago

Yeah I like that. Glad you like the changes :)