serversideup / webext-bridge

💬 Messaging in Web Extensions made easy. Batteries included.
https://serversideup.net/open-source/webext-bridge
MIT License
547 stars 50 forks source link

`web_accessible` context #36

Closed martonlederer closed 2 years ago

martonlederer commented 2 years ago

Closes #35 and #12

martonlederer commented 2 years ago

✅ Ready for review + tested with onMessage and sendMessage (with tabId as destination)

thanhlmm commented 2 years ago

Hi @martonlederer , what needs to be done to make this MR merged? We also have this issue and want to fix it asap

martonlederer commented 2 years ago

The pr is ready, but it doesn't seem like the developer os merging a lot of prs. Let's hope it gets merged asap :)

thanhlmm commented 2 years ago

Hi @zikaari , can we move this PR forward?

zikaari commented 2 years ago

Apologies for the long delay folks, I've been working on a very important problem with webext-bridge.

@martonlederer Thank you the effort! v5.0.0 is no longer under development, please use the new framework available in next branch of this repo. Fortunately it is actually less work than what you have done already.

It is as simple as createEndpointRuntime('<endpoint_name>', <routing handler>), see implementation for popup or window as a reference.

Also see the CHANGELOG in next branch to get up to speed on upcoming major release of v6.0.0.

martonlederer commented 2 years ago

Wow thank you! That's amazing

zikaari commented 2 years ago

@martonlederer You dropped the PR, Is it working with next branch somehow?

martonlederer commented 2 years ago

@zikaari haven't been able to test that yet, I didn't have time to update my extension with it, so rn I just published my patch to npm, so it works temporary. Once I'm done with everything else, I'm gonna try and test it :)

thanhlmm commented 2 years ago

Hi @martonlederer, I wonder that can you share your publishing package? I need it on my project as well

Thank you for your hard work