search

serverstf / python-valve

A Python Interface to various Valve products and services
Other
235 stars 71 forks source link

Exit the rcon shell by Ctrl-D shortcut. #59

Closed CzBiX closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.02%) to 70.24% when pulling 0f0433e147d6329f8979b8c5f09ce799edd96b59 on CzBiX:patch-1 into 2cfbaa52df30924ce658dff123d6dae448cb5df6 on serverstf:master.

Yepoleb commented 6 years ago

It bugs me that _disconnect isn't called. That will leave the connection open until the socket is garbage collected. I know this is happens in the exit implementation as well, so it'd be great if you could fix it there as well, maybe using a shared _exit method. Otherwise a great addition.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 70.15% when pulling c2981c76bde9b151edfa457912304cf2a8927235 on CzBiX:patch-1 into 2cfbaa52df30924ce658dff123d6dae448cb5df6 on serverstf:master.

Yepoleb commented 6 years ago

Looks good to me. Thanks for your contribution!