search

service-cloud-voice / ServiceCloudVoiceLambdas

This application provides a set of Lambda functions, which are available within your Amazon Connect instance after provisioning the instance with your Service Cloud Voice contact center. You can use these Lambdas in Amazon Connect contact flows.
BSD 3-Clause "New" or "Revised" License
14 stars 18 forks source link

Pass-in at stack level - SALESFORCE_AUTH_ENDPOINT & SALESFORCE_REST_API_ENDPOINT_BASE #38

Closed vgw-chriskruger closed 1 year ago

vgw-chriskruger commented 1 year ago

I have a suggestion:

https://github.com/service-cloud-voice/ServiceCloudVoiceLambdas/blob/main/ServerlessApplication/ServiceCloudVoiceLambdas.yaml#LL200C11-L201C94

It would be good if some of these very likely to be modified variables could be passed in at the top level of the SAM template. We would like to be able to deploy this application via Terraform more easily using resource directives like https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/serverlessapplicationrepository_cloudformation_stack

vgw-chriskruger commented 1 year ago

I have made a PR to this effect. https://github.com/service-cloud-voice/ServiceCloudVoiceLambdas/pull/39

jinalkathiara commented 1 year ago

Closing this issue. We have merged your PR.