Replace EnvVar with EnvMapping to avoid ambiguity

servicebinding / spec

Specification for binding services to k8s workloads

https://servicebinding.io

Apache License 2.0

92 stars 35 forks source link

Replace EnvVar with EnvMapping to avoid ambiguity #132

Closed baijum closed 3 years ago

baijum commented 3 years ago

There is a corev1.EnvVar which is different from the values of Env.

Signed-off-by: Baiju Muthukadan baiju.m.mail@gmail.com

baijum commented 3 years ago

Having a listing of Environments is a bit strange and not what we mean. I agree that EnvVar is overloaded and we should not confuse it with corev1.EnvVar. What about EnvKey or EnvMapping? Whatever name we choose is not user facing and is only meaningful within the context of the spec.

EnvMapping sounds good to me. It's mapping for environment variables. I will update the PR.

baijum commented 3 years ago

@scothis Thanks for the approval.

I have updated the Schema also. Please take a look again!