vmware controller: Error message in mail not useful when creating instance with name either too small or too long

[AndreasTWolf]

[Version] V16.0 Fix 6 [Date] 2016/06/26

[Test category] Creative

[Description] Error message in mail not useful when creating instance with name either too small or too long [Steps to reproduce] create vmware instance with target name larger then 63 chars or with 1 char. [Expected result] Error message which tells me that the name is too long or too short [Observed result] Email with following content: Dear Ms. Julia, The subscription 'VMware_Original_With_ALL(4)' for the customer with the ID 'da530744' could not be activated. The service instance could not be provided. CORBA MARSHAL 1330446347 Maybe; nested exception is: org.omg.CORBA.MARSHAL: WARNING: IOP00810011: Exception from readValue on ValueHandler in CDRInputStream vmcid: OMG minor code: 11 completed: Maybe With best regards. This email has been automatically generated. Please do not reply to this email [Details] See above;

[Messages and logs]

[GoebelL]

@StavrevaS The issue #187 is also concerning error messages in mails. In this context, if you are around there, could you check please if this issue is valid? Thanks.

[StavrevaS]

Fixed with commit.

[elfriedegoetz]

MIME-Version: 1.0 Message-ID: 1084195829.0.1469177468659.JavaMail.service@example.com Subject: Provisioning process for subscription 'VMware_4_Nics_Preset' Content-Transfer-Encoding: 7bit To: tpadmin@tp.com Content-Type: text/plain; charset=UTF-8 Reply-To: service@example.com From: service@example.com

Now I get the following message: Dear user, The current operation on subscription 'VMware_4_Nics_Preset' for customer '82c2686e' has been suspended (Instance: '1469177466721'). Reported problem: Invalid instance name a (Pattern: ^[a-zA-Z0-9][a-zA-Z0-9-]{0,61}[a-zA-Z0-9]$).
To continue automatic processing, please click the following URL:http://estgoetz.intern.est.fujitsu.com:8880/oscm-app/notify?sid=1469177466721&cid=ess.vmware&_resume=yes If the problem cannot be solved and the processing cannot be continued, please terminate the subscription and create a new one.

But this link does not make sense URL:http://estgoetz.intern.est.fujitsu.com:8880/oscm-app/notify?sid=1469177466721&cid=ess.vmware&_resume=yes

[StavrevaS]

Set severity to minor

[GoebelL]

If the link does not make sense, it should be quick to fix by removing it.

[StavrevaS]

Preparing mails is a central method which may affect other functionality. Quick fix for 16.1 GA2 is not possible.