servicecatalog / development

An Enterprise-ready Cloud Services Management Software
http://openservicecatalogmanager.org
Apache License 2.0
39 stars 27 forks source link

User assignment to subscription does not always work; browser hangs (addRevokeUser issue) #563

Open ghost opened 7 years ago

ghost commented 7 years ago

[Version] 16.1 fix5+ 2017/02/01

[How to reproduce] Using FF, (did not try others)

  1. supplier creates marketable service and publishes it on marketplace
  2. customer admin subscribes to marketable service
  3. customer tries to assign another user to subscription in Account/Subscriptions

[Expected result] user can be assigned to subscription

[Observed result] operation does not return (hangs)

[Details] if I press back on the browser, and go to Account/Subscriptions, choose the subscription, I see the user has "sometimes" been assigned correctly, sometimes not. Usually if I assign 3 users or more it works correctly

grubskim commented 7 years ago

I have tried to reproduce it. I have been assigning users in different batches from one to five at a time. This seems to be working fine. Also tried going back with the browser button or by clicking on a different link and going back. Users were assigned properly 100% of the time. I have a very simple service and 6 users in total, one being the customer admin which i use for assigning.

Can you advise if I have to do something more to reproduce it? Or can you still reproduce it?

grubskim commented 7 years ago

We have tested also on another environment with the same result. Please see my previous comment. Closing until this can be reproduced again.

ghost commented 7 years ago

[Version] 2017/02/27 error still occurs I attached a bes logfile, maybe it is the error causing the problem. bes_system_log.txt

GoebelL commented 7 years ago

@SylviaDehn Which JDK version are you using with this glassfish?

ghost commented 7 years ago

[Build] 16.1 fix6+ 2017/03/13 error still occurs

ghost commented 7 years ago

jdk version used is jdk1.8.0_121

DawidCh commented 7 years ago

[Details of fix] Configuration of glassfish needs to be modified. Queue mode needs to be modified to LOCAL instead EMBEDDED. The fact needs to be documented. @gertipoppel could you please close the issue if you document it? The command which needs to be run is: asadmin set server.jms-service.type=LOCAL on every domain.

gertipoppel commented 7 years ago

I have added the following note to both the Installation Guide and the Operator's Guide (Appendix A: Application Server Resources, section JMS Queues, both for bes-domain and indexer-domain):

Make sure that the JMS service type for the domain is set to LOCAL. In a default GlassFish configuration it is set to EMBEDDED. When using the installation scripts for installing OSCM, the service type is set to LOCAL automatically.

If you need to change the service type manually, you can run, for example the following command: asadmin set server.jms-service.type=LOCAL

This fix will be available as soon as the GlassFish feature branch is merged to master.

DawidCh commented 7 years ago

Issue got back in webtests.

DawidCh commented 7 years ago

The issue cannot be reproduced locally. It shows only sometimes on automated tests.

GoebelL commented 7 years ago

Switching the message queue type to LOCAL for Glassfish server has clearly improved the situation. Although for unknown reason the issue seldom reappeared in automated tests, there is no practical impact evidence as it is no longer reproduced manually. The issue remains open with lower severity. I adapt the target milestone and priority accodingly.

kwodzynski commented 7 years ago

Yesterday I was able to reproduce these issues manually while testing bug #645. The problem occurred when I tried to assign a few users to subscription, but only for the second attempt and thereafter (for the first attempt it was working correctly). After switching the message queue type to LOCAL, I can no longer reproduce the problem.

kwodzynski commented 7 years ago

I repeated my test on build BES_MASTER_DELIVERY-10192017/04/20. I can no longer reproduce the problem.