search

servicecatalog / development

An Enterprise-ready Cloud Services Management Software
http://openservicecatalogmanager.org
Apache License 2.0
39 stars 27 forks source link

Localization cache hit rate #60

Open StavrevaS opened 8 years ago

StavrevaS commented 8 years ago

Debug tracing of our professional service team shows that the localization cache of OSCM is not used efficiently. This issue should be investigated and fixed.

DawidCh commented 8 years ago

Do we have any more information about the issue? Is the hit rate to high or to low?

StavrevaS commented 8 years ago

The hit rate is to low. This is probably because, there is almost everywhere in the code usage of a new LocalizerFacade instance which contains the cache. The cache is initialized (cleaned) each time, a new instance is created.

GoebelL commented 8 years ago

The localization cache has been implemented very long ago. I admit that it's not so effective, as it's scope is limited to DB transactions and not persistent between API calls. However it's always been working correctly and has never been changed.

We don't plan for changing this implementation, unless it's causing any trouble. Since it's been in use for a long time, I don't expect any problems. But if you consider such, please provide us the respective evidence.