Repeated subscription modification error

[GoebelL]

[Environment] 17.4 Glassfish, custom controller

[How to reproduce]

1. Async subscription modification with custom controller is attempted with invalid parameter.
   (e.g. value of disk size paramater exceeding capacity that can be provided by the cloud side)
2. As subscription is back to ACTIVE state, user repeats modification with corrected the parameter
3. Error from Exception is shown in subscription UI

[Detail] Error occurs in APP attempting to persist parameters with null values. See attached log

[GoebelL]

app_server_log_from_repeated_modify_after_aborted_subscription.txt

[GoebelL]

See around line 108.

[GoebelL]

[additional info] The issue should be reproduce-able with OSCM sample controller, when throwing an APPlatformException in dispatch() (Dispatcher.java) at point when handling case MODIFICATION_REQUESTED.

[StavrevaS]

The parameters coming from OSCM to APP can be null, but APP converts the null values to empty strings. The same should be assured about changed parameters coming from the controller side (with InstanceStatus.setChangedParameters). Please check this issue.

[GoebelL]

@kowalczyka Please take over at your site

[badziakp]

I checked method InstanceStatus.setChangedParameters using Sample controller. When this method gets a map with any parameter which value is null then the exception "org.postgresql.util.PSQLException: ERROR: null value in column "parametervalue" violates not-null constraint" is thrown and error log can be found in server.log of app domain.

[StavrevaS]

@badziakp it is exactly as I expected. Please solve with converting the null values to empty strings.

[grubskim]

Fixed with https://github.com/servicecatalog/development/pull/895

[GoebelL]

@SylviaDehn Please verify with last unit build

[ghost]

[Build] 17.3.1 verified with sample controller