servicecatalog / development

An Enterprise-ready Cloud Services Management Software
http://openservicecatalogmanager.org
Apache License 2.0
39 stars 27 forks source link

Fix for null parameters #895

Closed grubskim closed 6 years ago

grubskim commented 6 years ago

Null parameter values are changed to an empty string. Tested with the sample controller.


This change is Reviewable

StavrevaS commented 6 years ago

It would be even more secure to add null to empty string transformation into the InstanceParameter.setParameterValue(). The method InstanceParameter.setDecryptedValue() may also set the value, so BEFORE the encryption it should be checked if the value is null and transform it. So in this case the empty string should be encrypted in order to have the same result by decryption.

grubskim commented 6 years ago

Unit tests green, added @StavrevaS suggestion

grubskim commented 6 years ago

Please review and merge if okay.

StavrevaS commented 6 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

GoebelL commented 6 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable